PneumaticCraft: Repressurized

PneumaticCraft: Repressurized

50M Downloads

Condition: Items not working

duncanwebb opened this issue ยท 4 comments

commented

Minecraft Version

1.16.4

Forge Version

35.1.29

Mod Version

pneumaticcraft-repressurized-1.16.4-2.8.3-109

Describe your problem, including steps to reproduce it

The condition piece items returns false when the condition should be true.

This is an extract of Tek Stack's green house building program, and it is checking for 1024 item of cobblestone in a chest, this is actually true.

javaw.2021-01-03.15-21-07-714.mp4

2021-01-03_15 20 47

image

Any other comments?

The drone has 35 inventory upgrades, so it should be able to import both tools. But it is only importing the Netherite pickaxe.

You can't easily see the numbers on the sign with the GitHub player, but you can with an external player. The measure variable says 0, 0, 0.

commented

Works fine for me. I set up a smart chest full of advanced pressure tubes, and ran this program on it: https://pastebin.com/T5Xi26An

It correctly checks for 4000 or more tubes and writes the actual number found on the sign (4608 for a full smart chest: 64 * 72)

Also tested removing some tubes, adding some other items... all fine.

commented

Indeed, your program works just fine. And the condition is the same an in the greenhouse program.

I wonder if this is related to the original program was written for 1.7.10. I'll delete and add the components back in again.

Many thanks for testing this.

commented

Fixed in 2.9.0 release

commented

I imported Tekstack's program (https://pastebin.com/qLMM2w04 right?) and one thing I did notice is that "Match Durability" is enabled on the cobblestone's (and other blocks) item filter, whereas if you create a new item filter with cobblestone, it will (correctly) be in "Ignore Durability" mode. And of course the checkbox is greyed out, because cobblestone items don't have durability.

But of course back in 1.12 and earlier, items had the metadata byte, which was effectively also durability. So yeah I'm pretty sure this is an artifact of importing programs from an earlier release. Since I do want to preserve backwards compat as much as possible, I think I can see a fix for this...