PneumaticCraft: Repressurized

PneumaticCraft: Repressurized

50M Downloads

Drone fakePlayer name includes serialized TextComponent

telemenar opened this issue ยท 3 comments

commented

Minecraft Version

1.16.4

Forge Version

35.1.29

Mod Version

pneumaticcraft-repressurized-1.16.4-2.9.0-111

Describe your problem, including steps to reproduce it

Drone fakePlayer name includes serialized TextComponent
Example:
e6665b1e60ad4cee8ca0203cf34cf40f-TextComponent{text='telemenar', siblings=[], style=Style{ color=null, bold=null, italic=null, underlined=null, strikethrough=null, obfuscated=null, clickEvent=null, hoverEvent=null, insertion=null, font=minecraft:default}}_drone

This causes all kinds of interesting errors. Like packet too long errors that cause the FTB Teams UI to fail to display at all.

Also this error:
[22:41:24] [Server thread/INFO]: [com.feed_the_beast.mods.ftbchunks.impl.ClaimedChunkManagerImpl:serverSaved:144]: java.nio.file.FileSystemException: ./world/data/ftbchunks/e6665b1e60ad4cee8ca0203cf34cf40f-TextComponent{text='telemenar', siblings=[], style=Style{ color=null, bold=null, italic=null, underlined=null, strikethrough=null, obfuscated=null, clickEvent=null, hoverEvent=null, insertion=null, font=minecraft:default}}_drone.json: Filename too long

I think the fix is really simple:

fakePlayer = new DroneFakePlayer((ServerWorld) world, new GameProfile(getUniqueID(), ownerName + "_drone"), this);

I /think/ it will be fixed if that line ownerName.getString()

Any other comments?

commented

Yeah that's down to annoying change in vanilla between 1.15 and 1.16. Thought I'd caught all those but clearly not.

commented

Build 112 should fix this, and more: drone fake players should now have exactly the same rights as the owning player.

However, note that this build does require Forge 34.1.36 or newer (latest at time of writing).

commented

Fixed in 2.9.1