PneumaticCraft: Repressurized

PneumaticCraft: Repressurized

50M Downloads

Possible bug with PNC Armor Upgrades

NielsPilgaard opened this issue ยท 3 comments

commented

Relayed from EnigmaticaModpacks/Enigmatica6#2238

Minecraft Version

1.16.5

Forge Version

1.16.5-36.1.16

Mod Version

pneumaticcraft-repressurized-1.16.5-2.12.4-188

Describe your problem, including steps to reproduce it

dont know if it is a bug, but the armor upgrade of the armor set doesnt work right. it works on the chestplate and leggins, but only the toughness gets increased on the boots/helmet. Is it a bug or is it supposed to be this way?

2021-05-21_15 45 26
2021-05-21_15 44 49
2021-05-21_15 45 03

2021-05-21_15 45 13m.
2021-05-21_15 45 17
2021-05-21_15 45 23

commented

Odd. I suspect it might be a display bug only, but I'll look into it. There's no special piece-specific handling for the armor upgrade...

commented

This is what I see with the helmet & 4 Armor Upgrades:

image

The "Armor" and "Armor Toughness" lines appear twice, but that's expected, since the armor upgrades add separate armor boost attribute modifiers for those two attributes.

Also did a bit of debugging on the server-side calculations and the armor upgrades in all pieces are definitely being accounted for when incoming damage reduction is calculated.

Not sure which mod converts the textual attribute displays to icons (Quark maybe?) but my guess it's not (always) detecting all the item attribute modifiers reliably on the client...?

commented

Not sure which mod converts the textual attribute displays to icons (Quark maybe?) but my guess it's not (always) detecting all the item attribute modifiers reliably on the client...?

Me neither ๐Ÿ˜„ I'll try and figure it out. Thank you!