PneumaticCraft: Repressurized

PneumaticCraft: Repressurized

Mods
50M Downloads

Request: Allow tracking "minecart with chest"

Opened this issue ยท 3 comments

commented

Currently the Entity Tracking and Block Tracking upgrades ignore minecarts with chests. I'd like to request that they be tracked. (Maybe there's an argument to track all minecarts, I'm not sure.) I assume it's only living entities that are tracked now:

pnc-repressurized/src/main/java/me/desht/pneumaticcraft/client/render/pneumatic_armor/upgrade_handler/EntityTrackerClientHandler.java

Lines 94 to 96 in 8500828

for (Map.Entry<Integer, RenderEntityTarget> entry : targets.entrySet()) {
RenderEntityTarget target = entry.getValue();
if (!target.entity.isAlive() || player.getDistance(target.entity) > entityTrackRange + 5 || !entityFilter.test(target.entity)) {

No tracking currently:

image

Thanks.

commented

I assume it's only living entities that are tracked now...

My mistake, I see other entities are also tracked.

Here is a quick prototype of entity tracking on minecarts. Maybe hopper & chest inventories could be listed.

Non-container:
image

Container:
image

commented

Yeah probably no reason not to track these. Would be handy to find them in mineshafts...

Update: I'll include all minecart types as an option in the entity tracker (can use filter @minecart to select them, by the way).

I will not be including chest & hopper minecart inventories, mainly for technical reasons; that would involve some significant changes to the protocol to request entity inventory sync. That will likely happen in 1.17+, where a rewrite of the whole pneumatic helmet tracker protocol is planned anyway.

commented

Added in 2.13.0