Pressure chamber base volume changes when blocks are replaced
s-l-lee opened this issue · 4 comments
Minecraft Version
1.16.5
Forge Version
36.2.0
Mod Version
2.13.3-211
Describe your problem, including steps to reproduce it
- Build a pressure chamber larger than 3x3x3.
- Bring up the pressure chamber GUI and note the base volume.
- Break a pressure chamber block.
- Replace the broken block to complete the pressure chamber again.
- Bring up the pressure chamber GUI and note the change in the base volume.
Any other comments?
The base volume is multiplied by 2^3 for 4x4x4 pressure chambers and 3^3 for 5x5x5 pressure chambers with each repetition of steps 3 and 4 until it eventually overflows and wraps back around into the negatives.
Sure, no rush. Let me know if/when I should open a pull request or some other action on my part. I'm not familiar with this code and might not understand its conventions.
In the meantime, the in-game workaround seems pretty straightforward - break all pressure chamber valves, then replace them to reset the pressure chamber base volume.
Lastly, I just wanted to say the mod is great fun. I'm just only getting into it and greatly appreciate the progression in the PNC:R Manual.
OK, tested and looking good - thanks! No need to do a PR, I'll commit this now (and credit you in the changelog :). Will be in the next release (pretty soon).