Upgrading tier I lose the content of the pocket
JisuCraft opened this issue · 14 comments
Hi!
I'm playing ATM10 (1.21.1) .
I have upgraded from TIER 1 to TIER 2 and I have lost all the items inside the pocket.
in the meantime, you(or a op on the server if you are in multiplayer) can use the /ps list, command to find your pocket storage and recover it.
Hey, so, does ATM change the recipe at all? this is the normal tier 2 upgrade recipe.
What crafting interface was it done in? ive seen a few times where someone used an auto crafter, or a AE2 interface which bypassed the recipe before.
Hi! Yes, that's the recipe. I used a crafting on a stick located on his curios slot. I clicked the (+) button on the interface to load the recipe auto.
I have made some tests in a creative world, ans I think that only fails the tier 1 to tier 2 upgrade.... but not always... I thinks that works fine if I put the recipe manually in the table, and fails when I "auto-load" it with the (+) button of the JEI (I think that it's not JEI, it's EMI, an alternative)
huh, interesting, if you do more experiments, can you see if the tooltip in the source pocket storage still shows its ID, and if the resulting pocket storage has a ID in the tooltip?
i havnt been able to get it to happen on my end yet.
Hi again.... I have good news, and bad news.... I've been trying again, with tooltips shown to check the IDs, but I haven't been able to reproduce the issue again :/
I'm sorry If I made you lose your time... :(
its all good, if you can ever get it to happen again and get any details let me know👍
You can reproduce the issue with this mod, FastWorkbench, EMI, and Polymorph. The combination of Polymorph and EMI makes the issue more visible but a variant of this also appears with just FastWorkbench installed alongside this mod. If you have two separate T1 units and place one of them in a T2 recipe, the output will be correct. However, if you then directly swap the T1 unit in the recipe (without removing anything) with the other one, then the output's ID will remain the same as the previous one and not update to match the current one. This is not the behavior when the mod is by itself.
After further investigation, I believe the issue comes from this line in FastWorkbench that is preventing some stack updates from propagating:
https://github.com/Shadows-of-Fire/FastWorkbench/blob/5c8ef5118afc6428424d97ba9b4986ec39c6f368/src/main/java/dev/shadowsoffire/fastbench/util/FastBenchUtil.java#L68
It looks like it needs to be updated from recipe.getClass()
to recipe.value().getClass()
.
I did a few tests with the recovered one and indeed when I used the + to add the recipe the result before removing did not have an ID listed and when I removed 1 gold from recipe and replaced it the resulting tier 2 had a matching ID
EDIT-I will hold onto them if you want me to test for anything in particular I will check this post but I believe it is more a problem with EMI
Hmm, i had hopes that maybe JEI was caching the craft result, but i still cant reproduce it in dev lol, unless something else in ATM10 is caching it? even tried installing EMI, still nothing.
Ok, so i cant reproduce this with just my mod and JEI/EMI, but something in ATM10 is messing with the recipe..., cause i installed ATM10, and sure enough, doesnt work when autofilled...
Edit, removing fast workbench, or EMI fixes it, but i cant reproduce it with just those mods installed... so its gotta be something else still...
@billyty08 @JisuCraft could you try updating fastworkbench to 9.1.2 in your pack and see if that fixes the issue for you?
It seems to have fixed both variations of the issue on my end.
I had to manually add it because CF launcher didn't list 9.1.2 to update fastbench but everything appears to be working now. Thank you for all the hard work you put into mods for our enjoyment!!
I had to manually add it because CF launcher didn't list 9.1.2 to update fastbench but everything appears to be working now. Thank you for all the hard work you put into mods for our enjoyment!!
ya, i dont think shadows marked it as 1.21.1 yet lol, but glad we got this figured out. :)