Polymorph (Fabric/Forge/Quilt)

Polymorph (Fabric/Forge/Quilt)

99M Downloads

Overlapping buttons when using Charm's portable crafting

Slugstur opened this issue ยท 2 comments

commented

image

Button overlaps with the crafting recipes book when opening the portable crafting from Charm.
Would be nice if they didn't overlap. Besides the polymorph button usually is right above the 'result square'.

commented

I cannot reproduce this problem, when using the Portable Crafting from Charm the button appears above the result slot as it's intended. I can see you have other mods installed, please reproduce this with only Charm and Polymorph in order to isolate any other mod incompatibilities. If this problem still occurs, then please list the Charm, Polymorph, and Forge/Fabric versions and a detailed list of instructions to reproduce the issue.

commented

@TheIllusiveC4 I have an answer for this because I've been running into the same issue with a modpack (and it's even more annoying when you have REI/JEI installed bc the recipe picker can get shoved to the far right and into the REI/JEI GUI with method 2 below). It's not a conflict between just Charm and Polymorph. It happens when you have Charm, Polymorph, AND Crafting Tweaks installed. This is because Crafting Tweeks moves the book over to the right side of the GUI and the Portable Crafting GUI moves the Polymorph icon to the right just enough to make the overlap.

Mods/Versions:
Minecraft 1.19.2
Fabric - 0.14.14
Balm (Fabric Edition) - 4.5.2
Charm - 4.4.4
Cloth Config API (Fabric/Forge) - 8.2.88-fabric
Crafting Tweaks (Fabric Edition) - 15.1.0
Fabric API - 0.75.1
Polymorph (Fabric) - 0.46.1

Replication instructions:
Set up - You will need a conflicting recipe. I assume you already have something in your testing kit, but if not, I used a datapack with a single recipe in it to create a conflict (stripped oak wood > spruce stairs). You can quickly create a pack for this with https://crafting.thedestruc7i0n.ca/.

Two ways of getting a weird overlay:
Method 1 - Crafting book starts closed.

  1. Get a vanilla crafting table in your inventory and make sure the crafting book is closed in the inventory. Click the Charm Crafting icon to open the Portable Crafting GUI.
  2. Put in the conflicting recipe. You will see this:
    image
  3. Bonus: upon clicking the Polymorph icon, the book is opened and the recipe picker is put in a weird spot:
    image

Method 2 - Crafting book starts open.

  1. Get a vanilla crafting table in your inventory and make sure the crafting book is open in the inventory. Click the Charm Crafting icon to open the Portable Crafting GUI.
  2. Put in the conflicting recipe. You will see this:
    image
  3. Bonus: upon clicking the Polymorph icon, the book is closed and the recipe picker is put in a weird spot:
    image

I got this replication with a fresh instance in Curseforge and only these three mods + their dependencies (everything's listed). I'm not entirely sure if this would be something to be fixed on the Polymorph side or the Crafting Tweaks side, since each mod works fine individually with the portable crafting table.