[Bug]: Performance issues with theurgy
klikli-dev opened this issue · 3 comments
Minecraft Version
1.21.1
What happened?
To make it short - is it possible to exclude specific machines/recipe types from polymorph?
It seems if polymorph is installed alongside theurgy, my use of RecipeCachedCheck seems to have cache issues (working hypothesis) and regular recipe checks by theurgy machines become extremely expensive.
As these machines have no UI for choosing recipe alternatives I think the best option would be to simply exclude them from polymorph's logic.
Is that possible?
See also klikli-dev/theurgy#230
How do you trigger this bug?
Install theurgy alongside polymorph
Loader
NeoForge
Loader Version
21.1.115
API Version
No response
Mod Version
Polymorph 1.0.7
Relevant Log Outputs
See also klikli-dev/theurgy#230
The new update has been released with the patch, please let me know if you encounter any still unresolved performance issues.
Sorry for the delay on this. The main issue at the heart of this is a critical bug in Polymorph's block entity checks. It's intended to be opt-in and should have excluded any block entities not specifically targeted, but currently this is not the case which causes some errant behavior between our mods. I've developed a patch for this to include in the next update and some quick profiling shows no more discernable difference in performance for affected block entities with or without Polymorph loaded.