Porting Lib

Porting Lib

Mods
455k Downloads

Botania Terrasteel Will Crit effects always happening without crit

Partonetrain opened this issue ยท 4 comments

commented

When Porting Lib 2.3.4 is installed with Botania-1.20.1-443-FABRIC, the Terrasteel Will crit effects will always happen on hit (when it should be only on critical hit) if the player has any Will applied to their helmet

commented

As far as I can tell, it's because the PlayerMixin hard-returns true in the @ModifyVariable wrapper for the isSprinting result here:

Porting-Lib/modules/entity/src/main/java/io/github/fabricators_of_create/porting_lib/entity/mixin/common/PlayerMixin.java

Line 96 in aad1090

private boolean modifyResult(boolean value, @Share("original") LocalBooleanRef vanilla) {

That kind of behavior is somewhat problematic for any mod that doesn't use PortingLib.

commented

Can confirm this on my end

commented

Any update on if this can be fixed?

commented

Other than Botania depending on Porting-Lib for no other reason, I don't see an reasonable fix from the Botania side of things.