Porting Lib

Porting Lib

455k Downloads

Porting Lib's TagUtil redirects Netherite to a wrong tag

KonSola5 opened this issue ยท 4 comments

commented

case NETHERITE -> Tags.Blocks.NEEDS_NETHERITE_TOOL;

Fabric has a convention for higher mining levels, that being #fabric:needs_tool_level_x, where x is a tier number.

So in this case, the switch should say:
case NETHERITE -> new ResourceLocation("fabric:needs_tool_level_4")
(or a reference to said identifier in another class).

Fixing this would fix Alpha-s-Stuff/TinkersConstruct#81 in Hephaestus.

commented

private static boolean isCorrectTierVanilla(Tier tier, BlockState state) {

You might also want to include fallback for tiers 4 and higher in the isCorrectTierVanilla, since #fabric:needs_tool_level_x are honored for x tier.

commented

probably fixed on 1.19, will be cherrypicked to 1.20, 1.18 needs a fix in ForgeTags

commented

this is hopefully fixed on all versions now