Powah! (Rearchitected)

Powah! (Rearchitected)

Mods
3M Downloads

Power generation artificially delayed, producing less than advertised

yurikus opened this issue ยท 1 comments

commented

Version: (make sure you are on the latest version before reporting):

  • Minecraft: 1.20.1
  • Forge: 47.2.30
  • Powah: 5.0.5

Config values are set to generate 8K FE/t, single player world.

Issue description:

Power generation artificially delayed, producing less than advertised. See video repro below. You will find a spirited magmator trash canning energy with flux plug. Advertised generation is 8K FE/t, while real is 5K FE/t. Latter value is an average of alternation between 2K and 8K: (8+2)/2=5. due to an artificial 2 or 4 thick delay in the sync method.

Powah/common/src/main/java/owmii/powah/block/magmator/MagmatorTile.java

Line 70 in 62b7f55

sync(4);

Below is the delay computation.

Powah/common/src/main/java/owmii/powah/lib/block/AbstractTickableTile.java

Lines 62 to 64 in 62b7f55

// TODO what the fuck is this?
// this.syncTicks = Server.isSinglePlayer() ? 2 : delay;
this.syncTicks = delay;

...

Steps to reproduce:

https://youtu.be/XshM95DUrV0
...

commented

Same SImilar issue, misdiagnosed: #50, here I think you're correct the 100mb overrides the choice

Nitro magmator exhibits the same alternation issue with general.magmatic_fluids.lava = 100_000: https://youtu.be/HrdIv16ShsA

With that value set to 1M, we get steady 40K FE/t