Crash when opening Compact Machine UI containing Pretty Pipes (1.18.2 - v1.12.8)
Lordmau5 opened this issue · 4 comments
crash-2023-03-24_13.59.15-client.txt
They work fine inside the Compact Machine, but somehow the renderer for the Compact Machine UI causes my client to crash
This isn't an issue with Pretty Pipes. It seems Compact Machines doesn't properly call capability attachment events for its (what I assume to be) fake world, which is why this issue occurs.
To quote the following issue: CompactMods/CompactMachines#540
Looking into this more, this looks like it's more an issue on both sides. While I can add the capability support on my rendering world, Pretty Pipes should be null-handling itself as well. Please report this to them as well!
Additionally I noticed this issue is actually a duplicate of #138
Alrighty! But yeah, I don't know if BlockPos is meant to be nullable (IntelliJ didn't want to show me the proper sources in my dev environment just now) but I assume a null-check in https://github.com/Ellpeck/PrettyPipes/blob/main/src/main/java/de/ellpeck/prettypipes/network/PipeNetwork.java#L483 and thus returning an empty list doesn't hurt just to be safe 🙏 (I'm not sure if this could potentially cause issue with other mods in the future, too, such as if that one Immersive Portals add-on for tiny worlds would be ported to Forge)