Primitive Mobs

Primitive Mobs

10M Downloads

[SUGGESTION] Dynamic trees compat for grove sprites AI

Sunconure11 opened this issue · 9 comments

commented
commented

Yes, please.

commented

Good one. Will have to look into Integration.

commented

progress

Got some progress on it today. It's tricky. Might not be able to get the stump-color properly; but the branch color seems to work. The new saplings as well.

commented

Ok got it to work properly. Not going to implement specific AI to maintain the Dynamic trees for now but at least they will change color and have proper items. :)

commented

Hey. Just looking over your code. Once you get a Species object you can get the primitive leaves IBlockState by using species.getLeavesProperties().getPrimitiveLeaves(). No need to do a search in the world for the leaves. Might be more efficient.

Edit: Also if (state != null && state.getBlock() instanceof ITreePart && TreeHelper.isBranch(state)) can be reduced to if(TreeHelper.isBranch(state)) since it does all the checks anyway.

commented

It's in v.1.2.3.

commented

Would it be possible to add some support for the various addons that exist for DT, as well? Or should that already be possible with your code changes?

commented

Judging by the code it looks like it's already handled automatically.

commented

Thanks for the review @ferreusveritas ! Appreciate it. I have made the changes :)