Probably Chests

Probably Chests

3M Downloads

Crash and a note: See description

Jack-Papel opened this issue ยท 12 comments

commented

We've recently received a crash report on our mod, Paradise Lost. When inspecting the logs, I saw that your mod caused the crash. I've linked the report so you can see what the issue is.

On top of that crash, I noticed one other issue. The log refers to your placed lush pot feature as
ResourceKey[minecraft:worldgen/placed_feature / minecraft:lush_pot_placed]
with the Minecraft namespace instead of your own.
I would recommend you register them with your own namespace.

Thanks for reading. Have a good one.

commented

Alright that is weird. I will look into it in the morning.

commented

Alright that is weird. I will look into it in the morning.

thx, look forward to your early reply.

commented

I just tested the mod with paradise lost and did not get the same error you did. in fact the error you got should be impossible as the piece of code it is referring to has a check that gets the absolute value before passing it into the random so I have no idea how that could be causing an error, and the mod should not be loading that placement feature inside the aether in the first place. I made a few changes to the way the placement modifier works so try the jar in this zip and see if the problem persists. probablychests-0.3.1.zip

oddly seem to still be crashing with the new version of the mod installed, ill send the logs if you need

Did you try the latest version i pushed to curseforge? the one i sent you in that link still had the problem.

I'm sorry but I still met crash error when entering the aether dimension with ProbablyChest mod, while it goes right after i delete the mod even with the latest version(v-0.3.1)

image
minecraft-exported-crash-info-2022-04-21T16-25-31.zip

commented

Could you make sure that you are using the 0.3.1 from curseforge and not the one i sent in the zip above? I looked at your crash log and it says it called the random on line 59 but that line number is what it was in the zip file and not the one i pushed to curseforge. The error you are getting is impossible in the proper version.

commented

This bug has been fixed with the addition of a check of the bounds of the random to prevent errors. Release 0.3.1 has been uploaded to curseforge.

commented

Thanks for letting me know. Do you currently have mods that modify the world height of either the overworld or the nether and how are they being modified?

commented

I just tested the mod with paradise lost and did not get the same error you did. in fact the error you got should be impossible as the piece of code it is referring to has a check that gets the absolute value before passing it into the random so I have no idea how that could be causing an error, and the mod should not be loading that placement feature inside the aether in the first place. I made a few changes to the way the placement modifier works so try the jar in this zip and see if the problem persists.
probablychests-0.3.1.zip

commented
commented

Thanks for letting me know. Do you currently have mods that modify the world height of either the overworld or the nether and how are they being modified?

if you still want to know, i have amplified nether installed which changes the nethers hight

commented

I just tested the mod with paradise lost and did not get the same error you did. in fact the error you got should be impossible as the piece of code it is referring to has a check that gets the absolute value before passing it into the random so I have no idea how that could be causing an error, and the mod should not be loading that placement feature inside the aether in the first place. I made a few changes to the way the placement modifier works so try the jar in this zip and see if the problem persists. probablychests-0.3.1.zip

oddly seem to still be crashing with the new version of the mod installed, ill send the logs if you need

commented

I just tested the mod with paradise lost and did not get the same error you did. in fact the error you got should be impossible as the piece of code it is referring to has a check that gets the absolute value before passing it into the random so I have no idea how that could be causing an error, and the mod should not be loading that placement feature inside the aether in the first place. I made a few changes to the way the placement modifier works so try the jar in this zip and see if the problem persists. probablychests-0.3.1.zip

oddly seem to still be crashing with the new version of the mod installed, ill send the logs if you need

Did you try the latest version i pushed to curseforge? the one i sent you in that link still had the problem.

commented

e i sent

oh not yet ill try it tomorrow