Project Expansion

Description
When you have a collector feeding a ProjectE Condenser (either mk1 or 2) and save the game, the game hangs.

Minecraft Version
1.20.1

ProjectExpansion Version
1.1.1 for 1.20.1

Forge Version
47.3.3

Reproduction Steps

Place down a collector connected to a condenser from ProjectE (mine was mk2 for example, with a final collector stuck to it)
Save world.
Game hangs forever.

Crash Report/Logs
N/A

Other Mods

I've finally found the source of this, it seems to be freaking out and getting into an infinite loop when reading a block while saving its data
I'm still not sure exactly why that's causing the problem, but it is what's causing the problem
So I'm just going to remove the protection of writing a value larger than our maximum which is causing that read (we already recheck this on load, and there are protections elsewhere) and call it good

ProjectExpansion/src/main/java/cool/furry/mc/forge/projectexpansion/block/entity/BlockEntityEMC.java

Lines 224 to 226 in 460c50c

    
           if (getStoredEmcBigInteger().compareTo(getMaximumEmcBigInteger()) > 0) { 
        
               emc = getMaximumEmcBigInteger(); 
        
           }

Thanks, any fix that can remove this issue is a gamechanger.

Fixed in 1.1.2

	if (getStoredEmcBigInteger().compareTo(getMaximumEmcBigInteger()) > 0) {
	emc = getMaximumEmcBigInteger();
	}

Share to