Project Expansion

Project Expansion

5M Downloads

[BUG]: Basic collector doesn't fill klein stars

BatBrine opened this issue ยท 1 comments

commented

Description
Klein stars don't get filled when put in the basic collector mk1. After taking a quick glance through the code it looks like the issue is on line 164 of the BlockEntityCollector class. getStoredEmcBigInteger().min(generated.toBigInteger()) returns 0 if the collector makes less than 1 emc/tick since generated.toBigInteger() gets rounded down.

Minecraft Version
1.20.1

ProjectExpansion Version
1.1.2

Mod Loader and Version
Forge 47.4.0

Reproduction Steps

  1. Place klein star inside basic collector with collector optimizations disabled
  2. The EMC stored in the klein star doesn't increase

Crash Report/Logs
N/A

Other Mods
This bug happens with just ProjectE and ProjectExpansion

commented

Really I might just remove the option to disable optimizations, it's half implemented and really not that useful