Project Expansion

When using a Hopper or other extraction method on an emc link it causes a divide by zero error in the hopper(or other block) this immediately crashes the game i dont think this is a mod interaction error as I have tried this with different items and storages
crash-2022-04-17_16.58.51-server.txt

Can reproduce in Minecraft 1.16.5 and Project Expansion 1.16.5-1.0.18.

To reproduce:

Place an EMC Link.
Place a hopper below the EMC link.
Set the EMC link to export an item that does not have an EMC value.
Crash - java.lang.ArithmeticException: BigInteger divide by zero because cost is zero

ProjectExpansion/src/main/java/cool/furry/mc/forge/projectexpansion/tile/TileEMCLink.java

Lines 230 to 235 in a7ae6a9

    
           long cost = ProjectEAPI.getEMCProxy().getValue(item); 
        
           IKnowledgeProvider provider = ProjectEAPI.getTransmutationProxy().getKnowledgeProviderFor(owner); 
        
           BigInteger emc = provider.getEmc(); 
        
           if (emc.equals(BigInteger.ZERO)) return ItemStack.EMPTY; 
        
           int count = amount; 
        
           long max = emc.divide(BigInteger.valueOf(cost)).longValue();

This is one cause for it however i dont think it is what caused my game to crash as the two items i was using have EMC andesite alloy from the create mod which has a value around 100 and a diamond saw which is around 8000

Fixed

1.16
1.15

	long cost = ProjectEAPI.getEMCProxy().getValue(item);
	IKnowledgeProvider provider = ProjectEAPI.getTransmutationProxy().getKnowledgeProviderFor(owner);
	BigInteger emc = provider.getEmc();
	if (emc.equals(BigInteger.ZERO)) return ItemStack.EMPTY;
	int count = amount;
	long max = emc.divide(BigInteger.valueOf(cost)).longValue();

Share to