Project MMO

Project MMO

10M Downloads

Crafting Requirement Ignored After Creative Mode [1.16.5]

SomewhatDamaged opened this issue ยท 2 comments

commented

Describe the bug
This bug only shows up if enter creative mode before entering survival and trying to craft.
Adding a crafting requirement of "cooking": 30 to minecraft:golden_carrot in req_craft.json shows up in tooltip fine but doesn't stop you from crafting it.

Expected behavior
The item should not be able to be crafted by a player without the required amount of cooking.

To Reproduce
Steps to reproduce the behavior:

  1. Add a requirement of "cooking": 30 to minecraft:golden_carrot in req_craft.json https://pastebin.com/9tJWFM31
  2. Create a game in creative mode
  3. Give yourself 1 carrot, 8 gold nuggets, and a crafting table
  4. Enter survival mode
  5. Try crafting a golden carrot
  6. Get golden carrot

Screenshots
image
image

Versions:

  • Minecraft: 1.16.5
  • Loader: 36.2.39
  • PMMO: 1.16.5-3.67.6
commented

Oof. Fair enough.

commented

Crafting reqs are busted. Every dev i've talked to that tries to implement something that limits crafting has had the same issue. Outside of hardcoding something directly into the GUIs that handle crafting (which you can't really do for other mods, and so you can only really affect vanilla), there is no clean or sure-fire way to do it. This is why crafting reqs were removed in the rework. It works only some of the time in the legacy implementation and breaks quite easily when other mods are introduced.