Project MMO

Project MMO

10M Downloads

Shovels Require Mining Skill Instead of Excavation

CheezBallzFTW opened this issue ยท 3 comments

commented

Describe the bug
All the modded shovels have a Mining skill requirement instead of an Excavation skill requirement.

Expected behavior
The shovels should require Excavation skill like the vanilla shovels correctly do.

To Reproduce
Steps to reproduce the behavior:

  1. Have a shovel added from a mod.
  2. Check the shovel in the creative menu or jei.

Versions:

  • Minecraft: 1.19.2
  • Loader: Forge-43.1.47
  • PMMO: 1.19.2-0.5.5
commented

could you please provide an example mod where this occurs?

commented

Can confirm that Mekanism: Tools shovels have this issue.

image

commented

oh! right, this is working as intended. All AutoValue item tool reqs us this property
image

That said, AutoValues could use a slight expansion to set skills for the different tool types. That is a sensible expansion that won't be breaking. I'm going to slate that for 1.1.0 though so that will come in the release following 1.0.0 (which is coming next)