Project MMO

Project MMO

Mods
10M Downloads

Testing Output In Prod

SomewhatDamaged opened this issue · 3 comments

commented

Describe the bug

Project-MMO-2.0/src/main/java/harmonised/pmmo/registry/PerkRegistry.java

Line 72 in a105dfb

System.out.println("output: %s, perkOutput: %s".formatted(output, executionOutput));//TODO remove

Project-MMO-2.0/src/main/java/harmonised/pmmo/core/perks/PerksImpl.java

Line 46 in a105dfb

System.out.println("speedBonuse: %s".formatted(speedBonus));//TODO remove

Project-MMO-2.0/src/main/java/harmonised/pmmo/core/perks/PerksImpl.java

Lines 50 to 51 in a105dfb

System.out.println("per-Perk speedIn: %s".formatted(speedIn)); //TODO remove
System.out.println("per-Perk speedOut: %s".formatted(speedModification)); //TODO remove

Lots of spam in log:

output: {}, perkOutput: {}
speedBonuse: 0.0
output: {}, perkOutput: {}
speedBonuse: 0.0
output: {}, perkOutput: {}
speedBonuse: 0.0
output: {}, perkOutput: {}
[16:15:13] [Render thread/INFO] [minecraft/AdvancementList]: Loaded 19 advancements
output: {}, perkOutput: {}
output: {}, perkOutput: {jump_boost_output:0.40999998688697814d}
output: {}, perkOutput: {}
output: {}, perkOutput: {jump_boost_output:0.41099998688697814d}
output: {}, perkOutput: {}
output: {}, perkOutput: {jump_boost_output:0.41099998688697814d}

Expected behavior
No spam in log

To Reproduce
Steps to reproduce the behavior:

  1. Start new game
  2. Experience bonus logging

Screenshots
image

Versions:

  • Minecraft: 1.20.1
  • Loader: Forge-40.1.35
  • PMMO: 1.20.1-1.0.1
commented

Same versions as OP. Even turning off all the MS Loggy options in pmmo-common.toml:

        [Common."Ms Loggy"]
                #Which MsLoggy info logging should be enabled?  This will flood your log with data, but provides essential details
                # when trying to find data errors and bug fixing.
                "Info Logging" = []
                #Which MsLoggy debug logging should be enabled?  This will flood your log with data, but provides essential details
                # when trying to find bugs. DEVELOPER SETTING (mostly).
                "Debug Logging" = []
                #Which MsLoggy warn logging should be enabled?  This log type is helpful for catching important but non-fatal issues
                "Warn Logging" = []
                #Which Error Logging should be enabled.  it is highly recommended this stay true.  however, you can
                #disable it to remove pmmo errors from the log.
                "Error Logging" = []
                #Which MsLoggy fatal logging should be enabled?  I can't imagine a situation where you'd want this off, but here you go.
                "Fatal Logging" = []

I still get this log spam whenever a player jumps (three jumps generate three logs per player):

output: {}, perkOutput: {jump_boost_output:0.41349998688697814d}
output: {}, perkOutput: {jump_boost_output:0.41349998688697814d}
output: {}, perkOutput: {jump_boost_output:0.41349998688697814d}
commented

@sandalle You'll just have to wait for Caltinor to get a look at it. I believe they are on vacation and can't make a fresh build until back at their machine.

  • 👍1
commented

OP correctly identified the cause. This was testing prints that I forgot to remove before publishing. They don't use the MsLoggy system. It will be fixed in the next update.

  • 👍1