[1.16.5] BYG Forge Tags Not Applying Restrictions
SomewhatDamaged opened this issue ยท 1 comments
Describe the bug
Adding #forge:ores/amaterine
to req_break.json
doesn't end up applying the specific requirements to the blocks.
Expected behavior
Both kinds of amaterine ore should have the appropriate requirement set.
To Reproduce
Steps to reproduce the behavior:
- Install Oh The Biomes You'll Go
- Add
"#forge:ores/ameterine": {"mining":100}
toreq_break.json
- Join game and verify it hasn't got
Mining 100
as a requirement.
Versions:
- Minecraft: 1.16.5
- Loader: Forge-36.2.39
- PMMO: 1.16.5-3.69.0
Additional context
Setting the two blocks directly works.
Upon review, the method Xp.getElementsFromTags
specifically only queries the forge tags classes and does not query the actual registries for all tags. As such, only tags explicitly defined by forge work for tags. A fix would involve redirecting the tag getters to the registries in which they are stored, which may or may not require adding world access to the methods and and the entire call heirarchy.