Project MMO

Project MMO

Mods
10M Downloads

PMMO Advancement trigger not a valid criterion

Silvertide7 opened this issue ยท 0 comments

commented

Describe the bug
When creating an advancement with a pmmo:skill_up trigger and loading up a world it fails with the log error message: Parsing error loading custom advancement synapse:pmmo/combo_dex_5_con_5: Invalid criterion trigger: pmmo:skill_up. This worked fine in 1.19.2.

Expected behavior
pmmo:skill_up to work for advancement criteria.

To Reproduce
Steps to reproduce the behavior:
Create a new advancement that uses the pmmo:skill_up criteria:

{
    "display": {
        "icon": {
            "item": "minecraft:bubble_coral"
        },
        "title": {
            "text": "Agility 3, Swimming 3 - Dive"
        },
        "description": {
            "text": "You can dive off of cliffs into open water. This can be done by fast running and jumping off of cliffs into a wide open space."
        },
        "frame": "goal",
        "show_toast": true,
        "hidden": true
    },
    "criteria": {
        "requirement": {
            "trigger": "pmmo:skill_up",
            "conditions": {
            "player": [
                {"condition":"pmmo:skill_level", 
                "skill":"agility", 
                "level_min": 3, 
                "level_max": 20
                },
                {"condition":"pmmo:skill_level", 
                "skill":"swimming", 
                "level_min": 3, 
                "level_max": 20
                }
            ]
            }
        }
    }
}

The minecraft logs will show that this advancement failed to load.

Versions:

  • Minecraft: 1.20.1
  • Loader: 47.1.47
  • PMMO: 1.20.1-1.2.5