Project MMO

Project MMO

10M Downloads

[1.18.2] `pmmo:damage_boost` Perk Not Using `per_level` Value

SomewhatDamaged opened this issue ยท 1 comments

commented

Describe the bug
No matter if you set pmmo:damage_boost's per_level to 0.0 or 500.0, it doesn't change the damage added.

Expected behavior
Setting it to 0.0 should result in no bonus and 500.0 should result in silly damage.

To Reproduce
Steps to reproduce the behavior:

  1. Set per_level in pmmo-Perks.toml (for bows) to either of the values above
  2. Shoot zombies with bow
  3. See error

Screenshots
If applicable, add screenshots to help explain your problem.

Versions:

  • Minecraft: 1.18.2
  • Loader: Forge-40.2.10
  • PMMO: 1.18.2-6.2.3

Additional context
With per_level = 500.0

[30Sep2023 17:56:05.950] [Server thread/DEBUG] [harmonised.pmmo.util.MsLoggy/]: Pre-Perk Damage:9.84
[30Sep2023 17:56:05.950] [Server thread/DEBUG] [harmonised.pmmo.util.MsLoggy/]: Attack Type: RANGED_TO_MOBS | Damage Out: 14.268001

With per_level = 0.0

[30Sep2023 18:02:08.145] [Server thread/DEBUG] [harmonised.pmmo.util.MsLoggy/]: Pre-Perk Damage:7.872
[30Sep2023 18:02:08.146] [Server thread/DEBUG] [harmonised.pmmo.util.MsLoggy/]: Attack Type: RANGED_TO_MOBS | Damage Out: 11.808001

Checked 1.20.1:
With per_level = 500.0

[30Sep2023 18:24:44.026] [Server thread/DEBUG] [harmonised.pmmo.util.MsLoggy/]: Perk Executed: pmmo:damage_boost
[30Sep2023 18:24:44.027] [Server thread/DEBUG] [harmonised.pmmo.util.MsLoggy/]: Pre-Perk Damage:9.84
[30Sep2023 18:24:44.027] [Server thread/DEBUG] [harmonised.pmmo.util.MsLoggy/]: Damage Modified from 9.84 to 49209.84
[30Sep2023 18:24:44.027] [Server thread/DEBUG] [harmonised.pmmo.util.MsLoggy/]: Attack Type: minecraft:arrow | Damage Out: 49209.84
commented

I am unable to reproduce this error. I shot the wither once with no XP and did normal damage. with per_level set to 500 my next shot one-shot the wither. Is it possible you modified the per_level of the generic DEAL_RANGED_DAMAGE perk and not the RANGED_TO_MOBS or some mixed combination where the target and event were mismatched?