[1.20.1] Potions Have Extra NBT Data Added
SomewhatDamaged opened this issue ยท 4 comments
Describe the bug
When making potions, they sometimes have extra NBT data (brewXpAwarded) added to the potion that makes it problematic for other mods to interact with them.
{
Items: [{
Slot: 0b,
id: "minecraft:potion",
Count: 1b,
tag: {
Potion: "minecraft:awkward"
}
}, {
Slot: 1b,
id: "minecraft:potion",
Count: 1b,
tag: {
brewXpAwarded: 1b,
Potion: "minecraft:awkward"
}
}, {
Slot: 2b,
id: "minecraft:potion",
Count: 1b,
tag: {
Potion: "minecraft:awkward"
}
}
],
}
Expected behavior
Potions not to have extra data.
To Reproduce
Steps to reproduce the behavior:
- Brew an awkward potion
- Remove potion by single-clicking
- See error
Versions:
- Minecraft: 1.20.1
- Loader: Forge-47.1.47
- PMMO: 1.20.1-1.2.5
Unfortunately, that extra NBT is necessary to prevent players from pick-drop-picking the potion from the brewing stand and getting infinite XP. The same thing happens with the Tetra toolbelt. So the options are:
- no NBT to be compatible with other mods, but you can infini-farm xp
- NBT (as is), but you're not compatible
- No brewing event at all (aka remove it from the mod)
So leave it up to the author whether they want compat with abuse, or no-abuse but compat. That's reasonable.