Project MMO

Project MMO

10M Downloads

Perks Event Skill Filter

SomewhatDamaged opened this issue ยท 2 comments

commented

Describe the solution you'd like
Two ideas for the skill entry in perks:

#all would make the perk trigger for any skill going up. This would have the immediate use with pmmo:fireworks perks and would consolidate them all down to one perk entry.

["combat", "endurance"] allowing the skill field to take an array so it would apply for any of the listed skills. This would mean certain perks could have multiple skills that trigger them. ex:

		[[Perks.For_Event.SPRINT_JUMP]]
			skill = ["agility", "combat"]
			per_level = 0.001
			perk = "pmmo:jump_boost"

Why is this feature needed
pmmo-Perks.toml is a bit messy, and adding either an "#all" keyword or allowing it to take a list of skills would get rid of a lot of that. Also, it would allow for multiple skills to trigger the same perk.

Describe alternatives you've considered
Status Quo.

Additional context
Just a lazy Sunday afternoon's musing.

commented

I like this, and it's not too difficult to implement either.

commented

After review, this would require a significant rewrite of the perk system to account for config permutations. This will not be implemented.