Project MMO

Project MMO

10M Downloads

Blocks Travelled Doesn't Affect XP When Sprinting

SomewhatDamaged opened this issue ยท 7 comments

commented

Describe the bug
No matter how fast I move, my XP gain for sprinting is always 7

Expected behavior
Giving myself lots of extra speed /effect give SomewhatDamaged minecraft:speed 60 10 should make the number go up faster if AntiCheese for sprinting is disabled.

To Reproduce
Steps to reproduce the behavior:

  1. Disable AntiCheese for SPRINTING
  2. Add "xp" to the Info log
  3. Try regular sprinting (should get 7 XP per trigger)
  4. Give self a lot of extra speed (like with above command)
  5. Get same XP per trigger

Versions:

  • Minecraft: 1.20.1
  • Loader: Forge-47.2.19
  • PMMO: 1.20.1-1.2.19

Additional context

cats.say.the.darndest.things.mp4
commented

With "speed 1000" I was able to get 23 agility from sprinting.

Perhaps the bonus from movement should just be higher?

Maybe distance ^ 2?

commented

Does this same limitation happen when jumping off a cliff? I'm wondering if the speed boost from the effect is somehow downstream from the movement and therefore not calculated. If you still cap at 7 while sprinting off a cliff, then it's definitely a cap somewhere in the codebase.

commented

Jumping off a cliff worked.

[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:8}
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:7}
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:28] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:7}
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:37}
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:13}
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:45}
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:29] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:77}
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:108}
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:135}
[00:56:30] [Render thread/INFO] [minecraft/ChatComponent]: [System] [CHAT] You have reached level 15 in Agility and unlocked:
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:159}
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:30] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:182}
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:202}
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:220}
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains: 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterBonus): 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): 
[00:56:31] [Server thread/INFO] [ha.pm.ut.MsLoggy/]: XpGains (afterCheese): {agility:237}
[00:56:31] [Server thread/INFO] [minecraft/MinecraftServer]: SomewhatDamaged fell from a high place
commented

so much for a watery landing lol. okay. i'll take a look at when the effect speed amount is added and see if I can't capture that in the xp calculations.

commented

Could be that the speed I was moving just didn't make enough of a difference to get past the rounding. Perhaps I should redo on a plane with a LOT of speed...

commented

this issue get any fix?

commented

this issue get any fix?

It is on the tracker. it will be addressed when i get around to it.