Project MMO

Project MMO

10M Downloads

CTD with Iron's Spells 'n Spellbooks when trading with Priests

malice936 opened this issue ยท 5 comments

commented

Describe the bug
On first attempt at speaking with a Priest Villager from Iron's Spells 'n Spellbooks, the trade menu will open and the player can trade as normal, any subsequent attempt to interact in any way, including attacking causes the game to CTD.

Expected behavior
The ability to open a trade dialogue with the Priest more than once.

To Reproduce

  1. Open a trade dialogue with a Priest Villager.
  2. Close the dialogue.
  3. Attempt to open it again, or attempt to attack the villager.

Screenshots
If applicable, add screenshots to help explain your problem.

Versions:

  • Minecraft: 1.20.1
  • Loader: Forge-47.2.0)
  • PMMO: 1.20.1-1.2.18

Additional context
Crash report attached, and report being made on the Iron's Spells 'n Spellbooks github as well.
crash-2024-03-16_12.06.54-client.txt

commented

As discussed here, the mod developers have wrongly assumed that serializing the NBT on the client is unsafe and have built-in server-only logic into their serialization methods. This needs to be reported to the mod author for correction.

commented

This looks like an issue with one of Iron Spellbook's mixins. Have you asked them about this bug?

commented

I did say that I filed a bug report on their github as well, under "additional context"

commented

Also, as per usual with mod interaction problems, here is Iron's response to this, as well as a link to the report there.
image
iron431/irons-spells-n-spellbooks#353

commented

This happens in more ways than just trying to trade too. I get client crashes with Priests if they take damage as well.