Could be added "applies_to" in "perk = "pmmo:attribute"
Shadowyjp opened this issue · 8 comments
Describe the solution you'd like
Could be added "applies_to" in "perk = "pmmo:attribute"
Why is this feature needed
So, im trying to give attribute (critic chance) using combat xp and bow xp, but i dont want to have the critic chance from combat when im using a bow, or use the critic from archery when im use a sword. If have "applies_to" i could use it, and set as i want - Archery critic only applies in bows, and combat only in swords.
Describe alternatives you've considered
I know that have the damage_boost, but with the applies_to, could be done more things than i said.
pmmo:attribute is typically a consistent bonus. It can't really be turned on and off in this way because it is only applied—not removed. If you give a buff to the player's attribute, it will stick around until you remove it and it affects the entire player.
What would be better, to give "critical" damage, would be to make a damage boosting perk that has chance = 0.1 (10% chance) but gives a much larger bonus to damage.
See here for details on what chance does.
More and more i see the use for context in events. In any case, there is already a perk the temporarily gives attributes, pmmo:temp_attribute but it doesn't have the item discrimination that you want from the applies_to property. I think I need to finish the default packs for 1.21 first, but I could start working on this for 1.21
Probably not. For this to work right, I need to implement event contexts. That kind of overhaul usually isn't easily back ported. I won't know though until I've done it.
I'm saying probably not, to not get your hopes up. I would love to backport event context to all versions. I just don't know how invasive the changes will be that I have to do to make that happen.