Project MMO

Project MMO

11M Downloads

[1.21.1] Tooltips Not Reflecting XP Multipliers (server config)

SomewhatDamaged opened this issue ยท 1 comments

commented

Describe the bug
Adjusting the XP multiplier for a skill using scripting or datapack works, but item/block tooltips don't reflect the modifier.

Expected behavior
Tooltips should reflect exactly what you're going to get.

To Reproduce
Steps to reproduce the behavior:

  1. Make a .pmmo file as below
  2. Break a log with your fist, get appropriate XP (half normal, 50)
  3. Look at tooltip for log
  4. See error

Screenshots

Image

Image

Versions:

  • Minecraft: 1.21.1
  • Loader: NeoForge-21.1.145
  • PMMO: 1.21.1-2.7.32

Additional context

WITH config(server)
    set(global_modifier).value(1.0);
    set(skill_modifiers).value(woodcutting,0.5,crafting,0.5);
END
Catroaches.mp4
commented

I'll look into it. Bonuses and modifiers use a lot of contextual factors, so it can change from when you look at it to when you earn it. I'll have to consider how to convey that in a meaningful way. The easiest implementation would only factor in modifiers and disregard bonuses. That would be more stable.