Failed to process synchronized task errors
Silvertide7 opened this issue ยท 1 comments
Describe the bug
I'm flying around the map looking at world gen and I'm seeing a lot of these three errors pop up sequentially:
java.util.concurrent.CompletionException: net.minecraft.ReportedException: Saving entity NBT
at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:315) ~[?:?]
at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:320) ~[?:?]
at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1770) ~[?:?]
at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.doRunTask(BlockableEventLoop.java:148) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at TRANSFORMER/[email protected]/net.minecraft.util.thread.ReentrantBlockableEventLoop.doRunTask(ReentrantBlockableEventLoop.java:23) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.pollTask(BlockableEventLoop.java:122) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.runAllTasks(BlockableEventLoop.java:111) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.runTick(Minecraft.java:1155) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at TRANSFORMER/[email protected]/net.minecraft.client.Minecraft.run(Minecraft.java:807) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at TRANSFORMER/[email protected]/net.minecraft.client.main.Main.main(Main.java:230) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at java.base/jdk.internal.reflect.DirectMethodHandleAccessor.invoke(DirectMethodHandleAccessor.java:103) ~[?:?]
at java.base/java.lang.reflect.Method.invoke(Method.java:580) ~[?:?]
at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.runTarget(CommonLaunchHandler.java:136) ~[loader-4.0.39.jar%23100!/:4.0]
at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.clientService(CommonLaunchHandler.java:124) ~[loader-4.0.39.jar%23100!/:4.0]
at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonClientLaunchHandler.runService(CommonClientLaunchHandler.java:32) ~[loader-4.0.39.jar%23100!/:4.0]
at MC-BOOTSTRAP/[email protected]/net.neoforged.fml.loading.targets.CommonLaunchHandler.lambda$launchService$4(CommonLaunchHandler.java:118) ~[loader-4.0.39.jar%23100!/:4.0]
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandlerDecorator.launch(LaunchServiceHandlerDecorator.java:30) [modlauncher-11.0.4.jar%23105!/:?]
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:53) [modlauncher-11.0.4.jar%23105!/:?]
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.LaunchServiceHandler.launch(LaunchServiceHandler.java:71) [modlauncher-11.0.4.jar%23105!/:?]
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.run(Launcher.java:103) [modlauncher-11.0.4.jar%23105!/:?]
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.Launcher.main(Launcher.java:74) [modlauncher-11.0.4.jar%23105!/:?]
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:26) [modlauncher-11.0.4.jar%23105!/:?]
at MC-BOOTSTRAP/[email protected]/cpw.mods.modlauncher.BootstrapLaunchConsumer.accept(BootstrapLaunchConsumer.java:23) [modlauncher-11.0.4.jar%23105!/:?]
at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.run(BootstrapLauncher.java:210) [bootstraplauncher-2.0.2.jar:?]
at [email protected]/cpw.mods.bootstraplauncher.BootstrapLauncher.main(BootstrapLauncher.java:69) [bootstraplauncher-2.0.2.jar:?]
Caused by: net.minecraft.ReportedException: Saving entity NBT
at TRANSFORMER/[email protected]/net.minecraft.world.entity.Entity.saveWithoutId(Entity.java:1744) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.util.TagUtils.entityTag(TagUtils.java:86) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.core.Core.getReqMap(Core.java:393) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.client.utils.ClientUtils.lambda$cacheUnlocks$16(ClientUtils.java:70) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) ~[?:?]
at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179) ~[?:?]
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?]
at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133) ~[?:?]
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1939) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) ~[?:?]
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596) ~[?:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.client.utils.ClientUtils.lambda$cacheUnlocks$28(ClientUtils.java:70) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1024) ~[?:?]
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762) ~[?:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.client.utils.ClientUtils.cacheUnlocks(ClientUtils.java:42) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.client.utils.ClientUtils.sendLevelUpUnlocks(ClientUtils.java:102) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.network.clientpackets.CP_UpdateExperience.lambda$handle$0(CP_UpdateExperience.java:34) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/net.neoforged.neoforge.network.handling.ClientPayloadContext.enqueueWork(ClientPayloadContext.java:31) ~[neoforge-21.1.174-universal.jar%23406!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.network.clientpackets.CP_UpdateExperience.handle(CP_UpdateExperience.java:27) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/net.neoforged.neoforge.network.handling.MainThreadPayloadHandler.lambda$handle$0(MainThreadPayloadHandler.java:16) ~[neoforge-21.1.174-universal.jar%23406!/:?]
at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:60) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?]
... 22 more
Caused by: java.lang.IllegalStateException: Cannot encode empty ItemStack
at TRANSFORMER/[email protected]/net.minecraft.world.item.ItemStack.save(ItemStack.java:409) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at TRANSFORMER/[email protected]/it.hurts.sskirillss.relics.entities.SporeEntity.addAdditionalSaveData(SporeEntity.java:164) ~[relics-1.21.1-0.10.7.5.jar%23570!/:1.21.1-0.10.7.5]
at TRANSFORMER/[email protected]/net.minecraft.world.entity.Entity.saveWithoutId(Entity.java:1723) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.util.TagUtils.entityTag(TagUtils.java:86) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.core.Core.getReqMap(Core.java:393) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.client.utils.ClientUtils.lambda$cacheUnlocks$16(ClientUtils.java:70) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.accept(ForEachOps.java:184) ~[?:?]
at java.base/java.util.stream.ReferencePipeline$2$1.accept(ReferencePipeline.java:179) ~[?:?]
at java.base/java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:197) ~[?:?]
at java.base/java.util.Iterator.forEachRemaining(Iterator.java:133) ~[?:?]
at java.base/java.util.Spliterators$IteratorSpliterator.forEachRemaining(Spliterators.java:1939) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:509) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:499) ~[?:?]
at java.base/java.util.stream.ForEachOps$ForEachOp.evaluateSequential(ForEachOps.java:151) ~[?:?]
at java.base/java.util.stream.ForEachOps$ForEachOp$OfRef.evaluateSequential(ForEachOps.java:174) ~[?:?]
at java.base/java.util.stream.AbstractPipeline.evaluate(AbstractPipeline.java:234) ~[?:?]
at java.base/java.util.stream.ReferencePipeline.forEach(ReferencePipeline.java:596) ~[?:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.client.utils.ClientUtils.lambda$cacheUnlocks$28(ClientUtils.java:70) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at java.base/java.util.Spliterators$ArraySpliterator.forEachRemaining(Spliterators.java:1024) ~[?:?]
at java.base/java.util.stream.ReferencePipeline$Head.forEach(ReferencePipeline.java:762) ~[?:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.client.utils.ClientUtils.cacheUnlocks(ClientUtils.java:42) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.client.utils.ClientUtils.sendLevelUpUnlocks(ClientUtils.java:102) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.network.clientpackets.CP_UpdateExperience.lambda$handle$0(CP_UpdateExperience.java:34) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/net.neoforged.neoforge.network.handling.ClientPayloadContext.enqueueWork(ClientPayloadContext.java:31) ~[neoforge-21.1.174-universal.jar%23406!/:?]
at TRANSFORMER/[email protected]/harmonised.pmmo.network.clientpackets.CP_UpdateExperience.handle(CP_UpdateExperience.java:27) ~[pmmo-1.21.1-2.7.33.jar%23556!/:?]
at TRANSFORMER/[email protected]/net.neoforged.neoforge.network.handling.MainThreadPayloadHandler.lambda$handle$0(MainThreadPayloadHandler.java:16) ~[neoforge-21.1.174-universal.jar%23406!/:?]
at TRANSFORMER/[email protected]/net.minecraft.util.thread.BlockableEventLoop.lambda$submitAsync$0(BlockableEventLoop.java:60) ~[client-1.21.1-20240808.144430-srg.jar%23405!/:?]
at java.base/java.util.concurrent.CompletableFuture$AsyncSupply.run(CompletableFuture.java:1768) ~[?:?]
... 22 more```
It doesn't crash the game or anything, just thought I'd post it here in case you knew what as happening. If it's not a problem feel free to close.
**Expected behavior**
No errors
**Versions:**
- Minecraft: 1.21.1
- Loader: Neoforge 21.1.174
- PMMO: 1.21.1-2.7.33
This appears to be similar to #704 where the entity being saved is also attempting to save an itemstack that doesn't exist.
Found the line saving an itemstack without confirming it isn't empty
i'll make an issue for this.