Project Red - Expansion

Project Red - Expansion

31M Downloads

GateItemRenderer crashes with Refined Storage Patterns

dav20011 opened this issue · 2 comments

commented

Describe the bug
When rendering a Refined Storage Pattern the GateItemRenderer throws a MatchError and thus crashes the game.
The exact line is this one: https://github.com/MrTJP/ProjectRed/blob/publish/1.16/release/src/integration/scala/mrtjp/projectred/integration/GateItemRenderer.scala#L36
I think it is pretty obvious why this happens, patterns are no gate parts. The same error should occur with AE2 patterns.
I also noticed that some other items like Red Alloy Wire simply do not render as patterns instead of causing a crash.

To Reproduce

  1. Install ProjectRed and Refined Storage
  2. Create a pattern for any gate part
  3. Hold shift in the inventory to render the pattern item

Crash Log
I can add that upon request, but I don't think it is needed.

Versions

  • Minecraft Version: 1.16.5
  • CCL Version: 4.0.4.435
  • FMP Version: 3.0.3.122
  • Scorge Version: 3.1.3
  • ProjectRed Version: 4.10.0
commented

That's great. I tried a bit around and in fact it was another mod (not Optifine) that was fiddling around in rendering. I will report this to the respective author.

commented

This was fixed last night with 097bf31

Yes, nothing renders if the item stack is not the expected type. Don’t know why the pattern stack itself is being passed in here. Makes no sense.