PR makes lighting too dark.
luisfcosta opened this issue · 17 comments
Hey. First of all, let me both thank you and congratulate you on the PR. Quite fun and useful!
Now to my issue. I use the shaders mod, not for using third party shaders, but because I get better FPS with their built-in shaders than I do with vanilla minecraft. However, when I add PR lighting conditions change quite a bit and the game gets way too dark.
To illustrate the situation, here are two screenshots.
NO PR: https://www.dropbox.com/s/ow0x6re13a48q0o/NO%20PR.png
With PR: https://www.dropbox.com/s/lvsv3w27p5rzkhd/W%20PR.png
As you can see, with PR in mods folder, everything gets a bit too dark. (brightness settings in mine craft are unchanged as far as I can see). I also saw this in 1.6.4, although I never made the connection with PR since I had PR before I had shaders. Please PM me if you need more info.
Thank you!
EDIT: Forgot to mention that both screenshots were taken at the same in-game time of day.
Did you read the warning before downloading Project Red?
Not compatible with
- Optifine (not officially supported, but may work)
- Any type of shaders (do NOT report any graphical weirdness if you are using them)
Graphical weirdness is not caused by Project Red, it's how the shaders mod interacts with minecraft (and therefore mods).
I must confess I didn't read that. Close this if you must, but be aware that 65 other mods don't cause minecraft to go dark ;) Guess I'll have to pass on PR for now. The performance gains w shaders is too great right and all that darkness hurts my eyes. I'll keep on checking to see if some time later you find a way around it.
Plus I'd not consider this a graphical weirdness. Its just dark. No artifacts whatsoever.
UPDATE
I just tried PR without the PR-lighting package. It works. Great since I can keep all the other stuff.
So if the lighting module is causing the problem, it may be that the rendering classes don't clean up after themselves fully (some properties are changed for the next redraw??). That's one for @MrTJP to investigate as I have no idea how rendering works.
But yeah shaders/optifine/etc. can make strange things happen.
I might be able to also delve into the render code if @MrTJP doesn't want to right now.
Go ahead. But can't see how PR could be causing this.. It doesn't really do much to render lights.
On Jun 21, 2014, at 6:55 PM, Kenzie Togami [email protected] wrote:
I might be able to also delve into the render code if @MrTJP doesn't want to right now.
—
Reply to this email directly or view it on GitHub.
@luisfcosta does it happen just with the Illumination package installed (eg. without placed lights)? If so I think I know what might be up.
@kenzierocks What do you mean? If you are asking if it works with all other PR packages minus PR-lighting, then yes, only if I add PR-lighting does the issue arise. I haven't tried removing all of PR and just adding the lighting package. I guess I'd need PR-base as well?
@kenzierocks Sir, you are correct ;) As soon as I place a lamp the world goes bright again!
I just restarted the game and the server. Even after you log back in is still ok. So whatever happens just needs one lamp placed once to fix it.
EDIT: doesn't actually have to be placed, just brought into the main inventory.
Yea, I know exactly what's going on then. I'll have a patch tested as soon as I get home; or if anyone wants to test it themselves they just need to add this at the start of renders.scala -> RenderHalo. onRenderWorldLast
if (renderList.size == 0) returnGood work @kenzierocks! That did the job. I installed the shaders mod and was able to reproduce everything stated above. Then patched the file, rebuilt and now it works fine. I'll let you do the honours of submitting a PR as it's your fix.
Fixed via 7534f02