[1.12.2] Crash when rendering Mekanism items in creative tab
karelmikie3 opened this issue · 8 comments
Forge version: 14.23.4.2705 (latest recommended as of today)
Project Red version: 4.9.0.83
Mekanism version: 9.4.10.345
This rendering crash occurs when opening Mekanism's creative tab, I suspect it could occur every time an item from Mekanism is rendered. I tested this in an isolated environment with only Mekanism and Project Red and its required dependencies. This crashed and generated the following log.
I also tested it the the latest recommended Forge with Project Red build 4.8.6.74. This didn't crash when opening the Mekanism tab and never caused any crashes for me.
I suspect it might be related to mezz/JustEnoughItems#1247 as they share a similar-ish exception.
Duplicate of #1301
This is not a duplicate. It is a crash caused by you changing the underlying assumption that what is registered to the TESR dispatcher is what will be returned by get
.
Correct. Wrapping TESRs is the cleanest way to stop tiles from rendering on demand. It is still wired that Mekanism is caching TESRs in this way instead of just keeping track of the instance that was registered. Either way, I need a new approach to doing this.
Perhaps I should only start wrapping after initialization so Mekanism can get a chance to load everything first. I’d be surprised if this isn’t a one-off situation here. I don’t really see a reason for mods to be getting their own registered instance out of the dispatcher
looking at the mekainsm repository, it looks like a commit has been made to fix something with project red on their side, but I think there is still more to be done on PRed's side as well.
Can confirm it. Took me about 2 hours to track down. In combination with ThermalExp and its dependencies CodeCickenLib also throws an error when the entangloporter is loaded into JEI. Removing Project Red fixes it.
Heres my crash erport for further investigation: https://pastebin.com/hNfREpgz
The update fixed the issue! Tried it with every item from mekansim to reproduce the crash.