Multiple requests lag the server to point of freezing
octylFractal opened this issue ยท 10 comments
On a related note, #398 could be of interest
I wrote something to patch it; but I've been having trouble testing it due to the move to 1.7. If you want you can look at the changes I made in my patch-1
branch.
Hmmmmm, While working on this patch I discovered the true cause of the issue: lostHandleTick()
in RoutedCraftingPipePart. It seems to never exit.
I'm so close to a fix on this; but every time I stick it on my server which first gave this report, it keeps happening.
This fix relies on me knowing how this line is supposed to work:
unbalanced = unbalanced.filterNot(c => c.setsRequested > 0 && c.finalizeInteraction())
Is unbalanced supposed to retain (1) things with setsReq > 0
or (2) things with sets == 0
and (1) true
for finalize or (2) false
.
basically, it is filtering (retaining) all the things "c" that do NOT pass the conditions.
So, after the line, unbalanced should not contain anything that has setsRequested > 0 and has finalized its operation.
Also, what's the purpose of redoing the getMissingCount call before the final check?
Never mind, I see it recalculates from the added promises.