Project Red - Illumination

Project Red - Illumination

37M Downloads

Electrotine Thermal Expansion Integration Issue

oitsjustjose opened this issue ยท 4 comments

commented

So, it's hard to describe, but here's the flaw that I've found:

ss 2015-06-18 at 01 15 06

This is because you've registered Electrotine Alloy as "ingotElectrotine" and Electrotine Dust "dustElectrotine". Thermal Expansion automatically puts 2 and 2 together and assumes the dust is a pulverized version of the ingot. My only thought / suggestion is changing "dustElectrotine" to "powderElectrotine" or just plain "electrotine".

commented

But then it would go against the naming conventions. The solution here is to have Thermal Expansion include a way to blacklist certain dusts in their API.

commented

Suggestion: change the name of 'Electrotine Ingot' to something like 'Blue Alloy Ingot' (ingotBlueAlloy) or 'Electrotine Alloy Ingot' (ingotElectrotineAlloy), since currently the dust and the ingot are made of different materials, but have the same name.

commented

Electrotine Alloy Ingot.

genius

Will do. It actually is an alloy anyway, you mix it with iron...

commented

Fixed via 57cded5.