Project: Vibrant Journeys

Project: Vibrant Journeys

18M Downloads

Sea Oats placeable blocks are hardcoded

MaxNeedsSnacks opened this issue ยท 2 comments

commented

return (ground == Blocks.DIRT || ground == Blocks.GRASS_BLOCK || ground == Blocks.SAND);

Preferably, you'd either use instanceof checks here to make sure it can be planted on other blocks that extend DirtBlock (for instance, BoP dirt types) or make a tag (รก la vanilla #minecraft:bamboo_plantable_on) to make it configurable through datapacks which blocks plants should be able to be placed on

commented

Ah yes, sometimes I just type out my thoughts when adding behavior to blocks and forget to actually account for things like this. I'll take a look at the pr and put together a patch

commented

I saw the pr, I'm going to go for checking the block's material instead of tags to keep it small.