Glowing potions recipe not checking potion type
sfiomn opened this issue ยท 3 comments
Hello there,
I'm one of the founder of Minecraft Legendary Edition modpack, and we encounter quite a strange behavior in 1.20.1.
Using a brewing stand, redstone + any potion gives a long glowing potion.
After checking the code here : https://github.com/OrderedChaos-Dev/ProjectVibrantJourneys/blob/1.20.x/src/main/java/dev/orderedchaos/projectvibrantjourneys/common/PVJBrewingRecipes.java
It might be because the glowing potion is defined as Ingredient and not either Strict or PartialNBTIngredient :
private static final Ingredient GLOWING_POTION = Ingredient.of(PotionUtils.setPotion(new ItemStack(Items.POTION), PVJPotions.GLOWING.get()));
->
private static final StrictNBTIngredientGLOWING_POTION = StrictNBTIngredient.of(PotionUtils.setPotion(new ItemStack(Items.POTION), PVJPotions.GLOWING.get()));
Would you consider update your 1.20.1 version and see if it fixes our bug ?
Thanks in advance and have a great day
Hi, I've uploaded a test build here
I've verified the fix locally but would you be able to check if it works for your modpack as well?