Proportional Destruction Particles

Proportional Destruction Particles

13M Downloads

Grey particles with the Leaves block and others

TominoCZ opened this issue ยท 2 comments

commented

2018-10-27_12 47 49

This also happens with grass and other blocks that have a color multiplier for particles.
While looking at your code, I compared the 2 ParticleManagers and I noticed one thing that is actually quite important :D

In ParticleManagerMod, you call .setBlockPos(pos) when you create the new particle (here), but you don't in FBPParticleManagerMod (here).

The method .setBlockPos(pos) actually does't only set a private position variable in the particle, but it also applies the color multiplier of the block to the color channels of the particle (so that leaf particles aren't grey :D).

I actually made a similar mistake in my mod in versions 2.4.0 and older, not calling this method.. But fixed it in the new version 2.4.1.

I overrode .setBlockPos(pos) in FBPParticleDigging in 2.4.1 (so that it returns FBPParticleDigging and not ParticleDigging).

commented

Thanks! A new build will be released ASAP.

commented

This is now fixed in v1.2.3