Psi

Psi

45M Downloads

Block bounds for conjured lights only visually appear to be small

yrsegal opened this issue ยท 9 comments

commented

looking in the empty space around a conjured light acts like you're looking at the light itself.

commented

That's block states for you.

commented

dammit, block states

commented

Is this also why you can punch anywhere in the block containing a conjured light and it puts out the light? So that's unable to be fixed? Or should I open an issue for it? It's fairly inconvenient that you can so easily break the lights, unlike torches.

commented

world raytracing for breaking collision is based on Block.getBoundingBox however Vaz has only overridden Block.getSelectedBoundingBox which is client only. (https://github.com/Vazkii/Psi/blob/master/src/main/java/vazkii/psi/common/block/BlockConjured.java#L140)

So the block's true bounds for breaking is the full block but it displays the smaller one.

commented

Soo... Can we fix this then? Maybe @williewillus you could put out a pull request even?

Bonus points if we could make the light favor a side inside the block... Then they would be just like torches, which would be awesome.

commented

Was playing with Psi for the first time in a long time tonight and hit this issue again. Just thought I'd bump it, again. Please at least reopen this issue since it is indeed an issue and is fixable...

commented

This is a really annoying issue. :/

commented

I fixed this in #399!

Proof :p

Thanks @williewillus for the pointer to the issue.

commented

@Vazkii please merge it, it's such a long overdue quality of life improvement ๐Ÿ™‚