Mod Loader (Required)

Fabric

Minecraft Version (Required)

1.20.1

Mod Version (Required)

8.0.23

Notes (Required)

Every mod and datapack that tweakes shulker drop no longer works either, the shulker instead drop no shells whatsoever.

latest.log (Optional)

No response

Thanks for reporting. I'm unable to reproduce your issue. Shulker drops both from vanilla and data packs work fine for me in v8.0.23 on both Forge and Fabric.

So this might be a mod conflict, it would be great if you could do some tests with a subset of your installed mods to find out if another mod is conflicting.

I will try to, but LivingEntityMixin from PuzzlesLib might be the conflicting culprit as disabling it seems to give me back the ability to loot shulkers. I will give a more thorough test later today.
Speaking of which, I am also using carpet-rug, which allows me to modify how much shells do shulkers drop without a datapack. It uses a mixin to achieve this, I wonder that's it?

Yeah, that seems to be the issue.

For the implementation of my LivingDropsCallback which allows for modifying all loot dropped by an entity I capture all loot dropped throughout LivingEntity::dropAllDeathLoot so that I can process that list at the end (this is a direct port of the Forge event).

Carpet Rug never allows me to reach the end of LivingEntity::dropAllDeathLoot where captured drops are processed, so they are all lost, including drops added by Carpet Rug itself.

I moved my injection point for enabling the drops capturing, but I also built in a fail-safe shortly after LivingEntity::dropAllDeathLoot that checks if captured drops have been spawned in the world and if not rectifies that.

The fix is public as v8.0.24.

Thanks!