Puzzles Lib [Forge & Fabric]

Puzzles Lib [Forge & Fabric]

98M Downloads

[Bug]: performance issue

Flexz9 opened this issue ยท 4 comments

commented

Mod Loader (Required)

Forge

Minecraft Version (Required)

1.20.1

Mod Version (Required)

v8.0.24

Notes (Required)

https://spark.lucko.me/LC20GSuBX8

When 2 players are afk, this library is using 10% of each tick when we only have easy shulkers installed that this library is required for.
What we found in the spark link is that funnels from create get slowed down because of this library. This should not be the case.

latest.log (Optional)

No response

commented

Hmm, there is nothing going on in that code honestly. Just iterating over a very small map (should have two entries only if ESB is all you have installed).

I rewrote that piece of code a little, maybe it helps: https://cdn.discordapp.com/attachments/917550806922846299/1172996203491893308/PuzzlesLib-v8.1.8.548-1.20.1-Forge.jar

commented

I'll check it out and keep you posted.

commented

https://spark.lucko.me/6FWljYVTc1

It's slightly better then before I think. But I'll have to check once other players join.
Before replacing mod it was around 9ms / tick on my own, after 8.2ms / tick but I guess the restart also helped..

I'll keep it running and update tomorrow.

commented

Just to let you know I think we never really had any difference with this change.
Create funnels also had a performance update so we will update that when the addons update and hope it resolves the issue.