Pyrotech

Pyrotech

897k Downloads

Improve error reporting when duplicate recipe names are registered

SureenInk opened this issue ยท 1 comments

commented

I posted an issue a short time ago about "one or more entry values not copying to the correct id". At first, I thought this error was just having too many items, and so I close the issue. I've now since found out the real cause. Here is the error report I am getting: https://pastebin.com/pUcExh1u

The cause is coming from my CrucibleRecipes.zs file. Upon doing everything I can, I have figured out that it is coming from the "addRecipe" command of the StoneCrucible and BrickCrucible. By removing both of these, I have no further issues, but if I only remove one of them, it doesn't do anything. I've also included a modlist so you can ensure everything is up-to-date and that the conflict isn't being caused by another mod of mine.

CrucibleRecipes.zs: https://pastebin.com/N4CtXtGQ
Forge Version: 14.23.5.2383
Modlist: https://pastebin.com/6nF9fUqf

commented

Thanks for the report!

It looks like you've got some duplicate recipe names: clay_stone and clay_brick. Recipe names in the same registry must be unique and if you add recipes to the registry with the same name, it will cause this exact problem.

Each device has its own registry, so you could have a Stone Crucible recipe named clay_stone and a Brick Crucible recipe named clay_stone. There just can't be more than one of the same name for any given device.

Please leave this issue open because I want to look into adding better error reporting for this sometime.