Pyrotech

Pyrotech

897k Downloads

Custom hammers behaving strangely with granite anvil

codetaylor opened this issue ยท 2 comments

commented

Issue Description

Custom hammers aren't behaving as expected in the granite anvil.

What Happens

When trying to use a custom hammer, specifically primitivetools:primitive_hammer_dbf, both the cobbled limestone to limestone rock recipe and the limestone rock to crushed limestone recipe don't advance progress when struck.

Also, the stone to stone slab recipe (which requries a pickaxe) can be completed with the primitivetools:primitive_hammer_dbf hammer.

What You Expect to Happen

I expect that the custom hammer completes the hammer recipes and that it doesn't complete the pickaxe recipes.

Script

Relevant config entry:

S:HAMMER_LIST <
            pyrotech:crude_hammer;0
            pyrotech:stone_hammer;1
            pyrotech:bone_hammer;1
            pyrotech:flint_hammer;1
            pyrotech:iron_hammer;2
            pyrotech:gold_hammer;1
            pyrotech:obsidian_hammer;2
            pyrotech:diamond_hammer;3
            primitivetools:primitive_hammer_swf;0
            primitivetools:primitive_hammer_dwf;0
            primitivetools:primitive_hammer_gwf;0
            primitivetools:primitive_hammer_swv;0
            primitivetools:primitive_hammer_dwv;0
            primitivetools:primtiive_hammer_gwv;0
            primitivetools:primitive_hammer_swl;0
            primitivetools:primitive_hammer_dwl;0
            primitivetools:primitive_hammer_gwl;0
            primitivetools:primitive_hammer_sbf;0
            primitivetools:primitive_hammer_dbf;0
            primitivetools:primitive_hammer_gbf;0
            primitivetools:primitive_hammer_sbv;0
            primitivetools:primitive_hammer_dbv;0
            primitivetools:primitive_hammer_gbv;0
            primitivetools:primitive_hammer_sbl;0
            primitivetools:primitive_hammer_dbl;0
            primitivetools:primitive_hammer_gbl;0
         >

Affected Versions

  • Minecraft: 1.12.2
  • Forge: forge1.12.2-14.23.5.2836
  • Dropt: dropt-1.12.2-1.14.0
  • Pyrotech: pyrotech-1.12.2-1.0.3
  • Athenaeum: athenaeum-1.12.2-1.17.1
commented

Regarding the hammers from the PrimitiveTools mod working as pickaxes on the anvils, the mod's hammers extend the pickaxe class. To prevent the hammers from being used as pickaxes on the anvils, you'll have to blacklist the hammers using the pickaxe blacklist in the anvil_common section of the config/pyrotech/module.tech.Basic.cfg file.

commented

It looks like the root of this issue is the hammers being recognized as pickaxes because they extend the pickaxe class. To solve this, you'll have to blacklist the hammers in the pickaxe blacklist.

Note: Pyrotech's current logic doesn't allow a pickaxe that fails a blacklist test to also then be tested against the custom hammers. This will be changed in the next version, but be aware that even if you blacklist now, it probably still won't work because of the change in logic that needs to happen.