Pyrotech

Pyrotech

Mods
897k Downloads

GTCE pickaxe and shovel not dropping correct items when breaking blocks

Rarity1 opened this issue ยท 3 comments

commented

Issue Description

GregtechCE tools do not properly count as their material's corresponding harvesting level.

What Happens

Using Gregtech pickaxes all of the item drops are exactly the same regardless of mining level. The same is also true for Gregtech shovels.

What You Expect to Happen

The tools should definitely have different item drops. A Gregtech Brass pickaxe should drop low tier items when mining stone and a Gregtech Darmstadtium pickaxe should drop high tier items.

Affected Versions

  • Minecraft: 1.12.2
  • Forge: 14.23.5.2847
  • CraftTweaker:4.1.20
  • Dropt:1.16.1
  • Pyrotech:1.4.21
  • Athenaeum:1.17.4
  • GregtechCE: 1.9.0.481
commented

GTCE MetaTool doesn't properly implement Item#getToolClasses. Similar to #274

commented

Because GTCE overrides a method that accepts null values, then explicitly throws an exception if there is a null value.

    public int getHarvestLevel(ItemStack stack, String toolClass, @Nullable EntityPlayer player, @Nullable IBlockState blockState)

https://github.com/GregTechCE/GregTech/blob/master/src/main/java/gregtech/api/items/toolitem/ToolMetaItem.java#L254