Pyrotech

Pyrotech

1M Downloads

Make dropt an optional dependency

Girouxdudes opened this issue ยท 1 comments

commented

I understand this might be impossible, just wanted to ask on the chance that this could be done. Crafttweaker has the ability to modify block drops already, which means having both can make dropt's features feel redundant. It would be nice if there was some way to make it so that, in the presence of crafttweaker, there was no need to also have dropt installed.

commented

TLDR; probably not anytime soon

PT integrates tightly with Dropt's API to manipulate drops and provide the intended PT experience. If Dropt was made optional, the absence of Dropt could be handled one of two ways as I see it: either have PT use CT to modify drops or simply not modify drops at all. Having PT use CT to modify drops would have to assume that CT drop modification has feature parity with Dropt, which I'm sure it doesn't. Not only that, but it would double the work needed to do any drop modifications. So nope. The second option is likely the option I would choose: if the Dropt mod isn't present, PT doesn't modify any drops. The only downside I see to this is ensuring that new / casual users have a good / intended mod experience. The Dropt mod would have to be marked as a required dependency on Curse so it downloads along with PT, but then have a soft dependency in PT so users could delete the mod if they wanted no drop modification. IIRC, this is what I did with Patchouli to mitigate the 'Why no guidebook? / Why guidebook no open?' spam in Discord.

So, yeah, maybe sometime. I guess it would save a ~140k download for a modpack and a tiny bit of RAM?