QuantumStorage

QuantumStorage

27M Downloads

Items disappear on shift-click to fill an itemstack

AMartinie opened this issue ยท 9 comments

commented

Easy recreation on my end. (Modpack ATM3 v5.4)
Shift-clicking an itemstack from your inventory into iron,gold, or diamond storage crates will fill the current stack in the crate and null the rest of the items.

MC version 1.12.2
Forge 14.23.1.2562

commented

This also seems to happen when shift-clicking items out of a Quantum Storage Unit, if there is a partial stack of the item it will take 64 from the QSU but only fill that partial stack.

commented

@modmuss50 did you break the shift click code in RC again?

commented

Uhh, I could have done. You use RebornContianer right?

commented

yup

commented

For those wondering, the recent release of RebornCore (3.6.1.183) has been tested and does not fix this issue.
EDIT: Also 3.6.2.187, 3.6.4.194...
EDIT2: Fixed in latest compiled RebornCore. Thanks CursedFlames!

commented

I have been away for the last 10 days so I have not been able to look into this

commented

Haven't tested it, but it looks like this issue might be caused by this line in the shiftItemStack method. The itemstack count seems to be set to a negative, which presumably empties the itemstack.

commented

This should be fixed with the next RebornCore update.

commented

Yup