Quark Oddities

Quark Oddities

22M Downloads

Management buttons breaking Tinkers GUIs

bonii-xx opened this issue ยท 2 comments

commented

Looks like your UI stuff is a tad too intrusive. It looks like a button ID conflict too, since my stencil table buttons are offset by 3.

java.lang.ClassCastException: vazkii.quark.management.client.gui.GuiButtonChest cannot be cast to slimeknights.tconstruct.tools.client.GuiButtonItem
at slimeknights.tconstruct.tools.client.module.GuiButtonsStencilTable.func_146284_a(GuiButtonsStencilTable.java:68)
at slimeknights.tconstruct.tools.client.module.GuiSideButtons.handleMouseClicked(GuiSideButtons.java:62)
at slimeknights.mantle.client.gui.GuiMultiModule.func_73864_a(GuiMultiModule.java:254)
at net.minecraft.client.gui.GuiScreen.func_146274_d(GuiScreen.java:540)
at net.minecraft.client.gui.GuiScreen.func_146269_k(GuiScreen.java:509)
at net.minecraft.client.Minecraft.func_71407_l(Minecraft.java:1694)
at net.minecraft.client.Minecraft.func_71411_J(Minecraft.java:1051)
at net.minecraft.client.Minecraft.func_99999_d(Minecraft.java:366)
at net.minecraft.client.main.Main.main(SourceFile:124)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at net.minecraft.launchwrapper.Launch.launch(Launch.java:135)
at net.minecraft.launchwrapper.Launch.main(Launch.java:28)
at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
at sun.reflect.NativeMethodAccessorImpl.invoke(Unknown Source)
at sun.reflect.DelegatingMethodAccessorImpl.invoke(Unknown Source)
at java.lang.reflect.Method.invoke(Unknown Source)
at org.multimc.onesix.OneSixLauncher.launchWithMainClass(OneSixLauncher.java:310)
at org.multimc.onesix.OneSixLauncher.launch(OneSixLauncher.java:395)
at org.multimc.EntryPoint.listen(EntryPoint.java:170)
at org.multimc.EntryPoint.main(EntryPoint.java:54)

2016-04-04_20 13 11

commented

This is on your end.

  1. You should check instanceof here, as any mod can add buttons to your GUI via forge's GUI events, as I do.
  2. For the same reason, this is also not safe.

Non the less, it also falls on me, as I don't properly cancel the event, so I'll get that sorted :V

commented

Thanks, guess I got all the instances where that can happen.