Quark Oddities

Quark Oddities

22M Downloads

[1.14] Model Override Config Not Working

oitsjustjose opened this issue · 1 comments

commented

Hey Vaz! I've got another one for you. I've been playing with Better Animal Models, and it seems as though there's some race condition between your model registry and theirs, as there's a random chance (between restarts) that a model will be normal or BetterAnimalModel's

Problem Overview

Disabling the mob variants option in the config is not enough, but disabling "Enable Pig", "Enable Chicken" and "Enable Cow" only somewhat works. It does prevent the mob variants, but does not prevent registration of your override (I think it's that the below lines don't check each config before registering).

https://github.com/Vazkii/Quark/blob/a65735b7765d207927d361f68a356f7a5d925f86/src/main/java/vazkii/quark/client/module/VariantAnimalTexturesModule.java#L63-L67

I've disabled every option for this and it doesn't seem to fix the issue of mobs randomly not using BetterAnimalModel's models.

commented