Quark uses the old Potion code from botania, which uses an old hack to do custom icon spritesheet.

In 1.9+, I encountered in botania that due to how MC orders its bindTextures, that approach breaks the in-game potion HUD. the proper way to do it is like this, overriding the actual methods to render those icons.

Not a problem yet bc there's no potions in quark yet, but just notifying of a bug-in-waiting since you linked to this code earlier this week somewhere :P

https://github.com/Vazkii/Quark/blob/master/src/main/resources/assets/quark/textures/misc/potions.png

Oh, didn't see you copied the backings to your sheet :p
Either way there's overrides to do the rendering now

There is one potion in quark, the Curse one.

On Sun, Oct 23, 2016, 17:55 Vincent Lee [email protected] wrote:

Quark uses the old Potion code from botania, which uses an old hack
https://github.com/Vazkii/Quark/blob/master/src/main/java/vazkii/quark/base/potion/PotionMod.java#L42
to do custom icon spritesheet.

In 1.9+, I encountered in botania that due to how MC orders its
bindTextures, that approach breaks the in-game potion HUD
williewillus/Botania#245. the proper way to
do it is like this
https://github.com/Vazkii/Botania/blob/master/src/main/java/vazkii/botania/common/brew/potion/PotionMod.java#L48-L79,
overriding the actual methods to render those icons.

Not a problem yet bc there's no potions in quark yet, but just notifying
of a bug-in-waiting since you linked to this code earlier this week
somewhere :P

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
#201, or mute the thread
https://github.com/notifications/unsubscribe-auth/ABtir7WW2vOgUSiSSJQLMUaUPPOgd9M6ks5q25GGgaJpZM4KeLm0
.