Quark Oddities

Quark Oddities

22M Downloads

Cross-mod door issue with Malisis Doors

xenoflot opened this issue ยท 9 comments

commented

Hi,

I've encountered a cross-mod bug with Quark and Malisis Doors. With both MalisisDoors and Quark in the pack, vanilla double doors functionally open and close normally however they don't render the change. The problem only occurs when both mods are in the pack. This has been tested with a stripped down pack with only JEI. Remove either Malisis Doors or Quark and the behaviour is as expected.

Single doors are not affected.

Ordinastie/MalisisDoors#111

Cheers!

MC 1.10.2
Forge 2107 - 2122
MalisisDoors 5.1.4
MalisisCore 4.2.7
Quark r1.0-59
Autoreglib 1.0-2

commented

Yes, looks like it the double door feature. I see a hasSubscription() method, does it mean it can be disabled by config ?
Otherwise, maybe simply check after preinit if Blocks.OAK_DOOR.class == BlockDoor.class.

commented

Perhaps as a long term fix, as time and enthusiasm permit, one or both mods could query the other when present and disable the function if the other one is taking care of it?

@Ordinastie Palaster recently expanded Quark's double-door functionality to include non-vanilla doors (such as those for Forestry). Does MD's double door feature also work with non-vanilla doors? I'm reluctant to set modifyVanillaDoors=false as I suspect that config option affects more than just the double-door anim.

commented

I provided a simple check for it in my previous comment. If you don't want to completely disable it, just have this check for all Vanilla doors in the event itself.

commented

Yes, the double door feature, in Quark, can be turned off in the config options if it is causing mod compatibility issues.

commented

@Vazkii @Ordinastie

Thanks, but! I just checked and Malisis Doors does NOT work with non-Vanilla doors thus disabling Quark's double-door functionality completely isn't desirable.

Since Quark's double-door functionality does cover non-Vanilla doors, I feel it would be best if Malisis Doors performed that check instead. Alternatively, have Quark only disable double-door functionality with Vanilla doors but continue to work for non-Vanilla doors.

Cheers

commented

I know this is closed, but the double door opening feature worked fine with Malisis' Doors provided the door animations were turned off. More specifically if the following config in malisisdoors.cfg is false: B:config.modifyVanillaDoors=false

If the above config is set to true, that is when the issue in question arises.

If Malisis' Doors does not override vanilla doors it works fine. Any chance you could change this so that double door opening is disabled only when Malisis' Doors overrides vanilla doors?

commented

I have the updated Quark mod and the updated AutoRegLib and all updated necessary Malisis mods. When only running Quark the double doors would open together. After running Malisis with Quark they open separately. Is there ever going to be a fix?

commented

I also tried to tweak the settings to get all the double doors open together.

If Malisis is enabled and Quark disabled, then all doors looks fine but only vanilla doors work together.
If Malisis is disabled and Quark enabled, then all doors will open together but vanilla doors have no textures.
If Malisis is enabled and Quark is enabled, then all doors looks fine and open together but they do not render the opening.

Is there any workaround how to get this fixed?

commented

This was closed 4 years ago. I expect it's worthwhile that you create a new issue.